Add line dash API #1225
Merged
Add line dash API #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Looks great!
I have made a couple of changes:
- Replaced the
Vecforsegmentswith a simplesliceby adding a lifetime toLineDashandStrokein f56c8a7. This way, users can avoid reallocating on every draw and we get to keep theCopytrait! - Removed the direct
lyon_algorithmsdependency in bace264, as we can access it throughlyonalready.
Let me know what you think and we can merge this 🥳
|
Changes look great, good call on the short lifetime and slice usage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
LineDashconfiguration toStrokeand usesRepeatedPatternfromlyon_algorithmsto closely mimic the HTML Canvas APIs for adding stroked line dash styling.I've updated the Solar System example to use a dashed line pattern for the orbit, which I think showcases this well.
A couple comments / questions:
Strokeis no longerCopy, I see no way around thisLineDashis only considered ifsegmentsis not empty. Should we instead use anOption?segments, as things may not render properly if negative or non-finite values are used. It is up to the caller to define this properly.Relevant canvas API spec:
https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-setlinedash
Screenshot:
